Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13076 )
Change subject: resource: Introduce a base class for the modem ...................................................................... Patch Set 3: (3 comments) https://gerrit.osmocom.org/#/c/13076/3/src/osmo_gsm_tester/modem.py File src/osmo_gsm_tester/modem.py: https://gerrit.osmocom.org/#/c/13076/3/src/osmo_gsm_tester/modem.py@322 PS3, Line 322: class ModemBase(log.Origin, metaclass=ABCMeta): Create a new ms.py file and name it MS or MSBase like we discussed (MS over modem). https://gerrit.osmocom.org/#/c/13076/3/src/osmo_gsm_tester/modem.py@339 PS3, Line 339: class Modem(log.Origin): This should be changed to: class Modem(ms.MS): https://gerrit.osmocom.org/#/c/13076/3/src/osmo_gsm_tester/suite.py File src/osmo_gsm_tester/suite.py: https://gerrit.osmocom.org/#/c/13076/3/src/osmo_gsm_tester/suite.py@26 PS3, Line 26: from . import osmo_nitb, osmo_hlr, osmo_mgcpgw, osmo_mgw, osmo_msc, osmo_bsc, osmo_stp, osmo_ggsn, osmo_sgsn, esme, osmocon, ms_driver, iperf3 Why this line changed here? -- To view, visit https://gerrit.osmocom.org/13076 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id547cdcc241a307a2ea59b5fbac6b8d7a9d95639 Gerrit-Change-Number: 13076 Gerrit-PatchSet: 3 Gerrit-Owner: Holger Freyther <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Sun, 03 Mar 2019 22:45:40 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
