Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13075 )
Change subject: resource: Use a factory to initiate a modem ...................................................................... Patch Set 5: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/13075/5/src/osmo_gsm_tester/resource.py File src/osmo_gsm_tester/resource.py: https://gerrit.osmocom.org/#/c/13075/5/src/osmo_gsm_tester/resource.py@29 PS5, Line 29: from . import bts_sysmo, bts_osmotrx, bts_osmovirtual, bts_octphy, bts_nanobts Missing import, test fails: + File "/home/jenkins/workspace/osmo-gsm-tester_gerrit/osmo-gsm-tester/selftest/../src/osmo_gsm_tester/resource.py", line 110, in <module> + None: modem.Modem, +NameError: name 'modem' is not defined -- To view, visit https://gerrit.osmocom.org/13075 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4baa791c92196cda477b2d969d4f67dfbe1152af Gerrit-Change-Number: 13075 Gerrit-PatchSet: 5 Gerrit-Owner: Holger Freyther <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Mon, 04 Mar 2019 16:24:20 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
