dexter has posted comments on this change. ( https://gerrit.osmocom.org/13082 )
Change subject: AMR: Add option to convert between bw-effient and octet aligned mode ...................................................................... Patch Set 2: > what I don't like here is that this implements "blind" change from > one type to another type, on a global scope for the entire MGW. > I'd much rather see this more fine-grained: Only on the AoIP-facing > connections, and only if the BSC actually asks us to. See my other > comment. I see the problem. I will check the specs what we can do here. Maybe we should even be more restrictive and configure at the BSC vty which exact packet format is spoken on the AoIP side. Maybe we can apply this to the HRv1 problem then as well. -- To view, visit https://gerrit.osmocom.org/13082 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id46a3622a6b1995d5fce4bc611d409bcb4aef13b Gerrit-Change-Number: 13082 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: dexter <[email protected]> Gerrit-Comment-Date: Tue, 05 Mar 2019 09:38:56 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
