Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13127 )
Change subject: TC_rach_content(): fail test explicitly ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/13127/2/bts/BTS_Tests.ttcn File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/#/c/13127/2/bts/BTS_Tests.ttcn@1024 PS2, Line 1024: if (test_failed == false) { What about simplifying: if (test_failed) Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("Some out of 1000 RACH requests timed out")); setverdict(pass); Misc_Helpers.f_shutdown(__BFILE__, __LINE__); -- To view, visit https://gerrit.osmocom.org/13127 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifff8b3b83eeedea0d308f7ab0bfe347e2dc278c8 Gerrit-Change-Number: 13127 Gerrit-PatchSet: 2 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Daniel Willmann <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Tue, 05 Mar 2019 15:07:41 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
