Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13115 )
Change subject: mgcp client: allow setting conn mode for CRCX and MDCX ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13115/1/include/osmocom/mgcp_client/mgcp_client_fsm.h File include/osmocom/mgcp_client/mgcp_client_fsm.h: https://gerrit.osmocom.org/#/c/13115/1/include/osmocom/mgcp_client/mgcp_client_fsm.h@53 PS1, Line 53: enum mgcp_connection_mode conn_mode; Can we call this and related symbols "forced_conn_mode" ? It's much more clear this way. -- To view, visit https://gerrit.osmocom.org/13115 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26be5c4b06a680f25f19797407ab56a5a4880ddc Gerrit-Change-Number: 13115 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-Comment-Date: Tue, 05 Mar 2019 15:17:49 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
