Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13126 )
Change subject: gsm-tester: Run the virtual tests as part of gerrit verification. ...................................................................... Patch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/13126/2/jobs/osmo-gsm-tester_run-gerrit.sh File jobs/osmo-gsm-tester_run-gerrit.sh: https://gerrit.osmocom.org/#/c/13126/2/jobs/osmo-gsm-tester_run-gerrit.sh@13 PS2, Line 13: export OSMO_GSM_TESTER_OPTS="-s nitb_sms:sysmo -s sms:sysmo -s gprs:sysmo -s nitb_netreg_mass" BW, now that I think about it, that's not going to work for gerrit job, since it runs in Prod setup with example/resources.conf.prod file which uses real modems, and nitb_netreg_mass uses osmo_bts_virtual, so no way the MS is going to work. If you use osmo-gsm-tester_run-gerrit.sh with the docker container and nitb_netreg_mass.conf.virtual, then either add "-s nitb_netreg_mass" here based on existance of an env variable passed to the script, or set OSMO_GSM_TESTER_OPTS here only if not set before. -- To view, visit https://gerrit.osmocom.org/13126 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28a5f29cedc2c788fcde35633db67e944a5509d7 Gerrit-Change-Number: 13126 Gerrit-PatchSet: 2 Gerrit-Owner: Holger Freyther <[email protected]> Gerrit-Reviewer: Holger Freyther <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Tue, 05 Mar 2019 15:46:31 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
