Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12899 )
Change subject: Log signals from VoiceCall dbus objects ...................................................................... Patch Set 1: This needs more some work. Second time the iface signals are attached, we get the signals twice because first one wasn't removed: 19:25:07.716201 tst /sierra_6: DBG: '/sierra_6/voicecall01':'org.ofono.VoiceCall'.PropertyChanged() -> State=alerting [trial-223↪voice:trx-b200↪/sierra_6] [modem.py:746] 19:25:07.716762 tst /sierra_6: DBG: '/sierra_6/voicecall01':'org.ofono.VoiceCall'.PropertyChanged() -> State=alerting [trial-223↪voice:sysmo↪/sierra_6] [modem.py:746] 19:25:07.875921 tst /sierra_7: DBG: '/sierra_7/voicecall01':'org.ofono.VoiceCall'.PropertyChanged() -> State=active [trial-223↪voice:trx-b200↪/sierra_7] [modem.py:746] 19:25:07.876545 tst /sierra_7: DBG: '/sierra_7/voicecall01':'org.ofono.VoiceCall'.PropertyChanged() -> State=active [trial-223↪voice:sysmo↪/sierra_7] [modem.py:746] We need to store the subscription returned during dbus_connect and then remove it once the call is removed with subscription.disconnect(). -- To view, visit https://gerrit.osmocom.org/12899 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0def02b9063f75ec32c8b9382bdb12d65e1fb9eb Gerrit-Change-Number: 12899 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Tue, 05 Mar 2019 18:33:39 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
