Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13118 )
Change subject: add osmo_sccp_addr_cmp(), osmo_sccp_addr_ri_cmp() ...................................................................... Patch Set 1: I think my original assumption was that we always talloc_zero() and hence the sccp_addr structs would always be zero-initialized and hence a memcmp() woould work. But of course, one can be more diligent/intelligent about it. Not +2ing due to max' valid comment about rc. -- To view, visit https://gerrit.osmocom.org/13118 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9e2add7bbfae651c04e230d62e37cebeb91b0f5 Gerrit-Change-Number: 13118 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Tue, 05 Mar 2019 20:50:49 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
