Max has posted comments on this change. ( https://gerrit.osmocom.org/13138 )

Change subject: rename bscconfig.h to configure.h, cleanup
......................................................................


Patch Set 1:

I think mscconfig.h would be better aligned with existing bscconfig.h and 
btsconfig.h in other repos. Also, looking at the build failure, is there reason 
why it couldn't be split away from this patch series into independent patch? Or 
at least moved earlier in the series?


--
To view, visit https://gerrit.osmocom.org/13138
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4f683be1f36f0630c83da54e02868aae847aeec
Gerrit-Change-Number: 13138
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <[email protected]>
Gerrit-CC: Max <[email protected]>
Gerrit-Comment-Date: Wed, 06 Mar 2019 14:32:12 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No

Reply via email to