Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13128 )
Change subject: TC_rach_content(): log successful allocations ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13128/1/bts/BTS_Tests.ttcn File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/#/c/13128/1/bts/BTS_Tests.ttcn@1012 PS1, Line 1012: log("[", i, "] CHAN RQD FN=", fn, " RA=", ra, " OK"); > > to see those in the pcap file […] 1- I'd argue it's not handy having 1k lines of logs of correct case. If for whatever reason you require the last correct one, then store it in a variable and print it on error. 2-If it fails there it can provide more info about the issue. -- To view, visit https://gerrit.osmocom.org/13128 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaeadb4866a0d30a447fda9ef22be050889bc0cee Gerrit-Change-Number: 13128 Gerrit-PatchSet: 1 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Daniel Willmann <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Wed, 06 Mar 2019 16:36:19 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
