Max has posted comments on this change. ( https://gerrit.osmocom.org/13241 )
Change subject: amr_test: add to .gitignore, use -noinstall flag ...................................................................... Patch Set 1: > On stream_stream_test_LDFLAGS there is an stream_stream_test_LDFLAGS = > -no-install, but on jibuf_jibuf_test_SOURCES there is not. I wonder if jibuf > also has this problem. It's kinda tricky to test: to reproduce it on my system for example I've got to 1st install libosmo-netif version which does not include functions used by jibuf_test and than try to build it to see if it fails. Personally I'd prefer to just enable '-no-install' globally for all the tests by default and be done with it. -- To view, visit https://gerrit.osmocom.org/13241 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I94ccff42dfba71aaf59bb30ca312db0bac58c27d Gerrit-Change-Number: 13241 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Alexander Huemer <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Pablo Neira Ayuso <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: steve-m <[email protected]> Gerrit-Comment-Date: Wed, 13 Mar 2019 16:36:45 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
