Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13163 )
Change subject: MCS: move Mode enum outside of class definition ...................................................................... Patch Set 4: (3 comments) https://gerrit.osmocom.org/#/c/13163/4/src/coding_scheme.h File src/coding_scheme.h: https://gerrit.osmocom.org/#/c/13163/4/src/coding_scheme.h@53 PS4, Line 53: enum Mode { GprsMode? Mode is just too generic. https://gerrit.osmocom.org/#/c/13163/4/src/coding_scheme.h@59 PS4, Line 59: const char *mode_name(enum Mode val); same https://gerrit.osmocom.org/#/c/13163/4/src/coding_scheme.c File src/coding_scheme.c: https://gerrit.osmocom.org/#/c/13163/4/src/coding_scheme.c@92 PS4, Line 92: const char *mode_name(enum Mode val) { same -- To view, visit https://gerrit.osmocom.org/13163 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3baaac7f1ca3f5b88917a23c1679d63847455f47 Gerrit-Change-Number: 13163 Gerrit-PatchSet: 4 Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-CC: Harald Welte <lafo...@gnumonks.org> Gerrit-Comment-Date: Wed, 13 Mar 2019 18:33:05 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
