Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13277 )
Change subject: add caller-owns-msgb variant osmo_sccp_user_sap_down2() ...................................................................... Patch Set 1: what about the proposal with the 'volatile select dispatch talloc context'? If we merge this patch, I think for sure the naming would have to be reworked. The '2' function suffix is normally used only in case we have a new API that deprecates older API. However, here we're adding something with different semantics, so those semantics should be expressed with something like _nofree or the like. This way it's more obvious what those symbols are about. -- To view, visit https://gerrit.osmocom.org/13277 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic818efa78b90f727e1a94c18b60d9a306644f340 Gerrit-Change-Number: 13277 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Fri, 15 Mar 2019 17:21:25 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
