Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13268 )
Change subject: oml: use oml_tx_failure_event_rep() instead of oml_fail_rep() ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13268/1/src/common/main.c File src/common/main.c: https://gerrit.osmocom.org/#/c/13268/1/src/common/main.c@196 PS1, Line 196: oml_tx_failure_event_rep(&bts->mo, OSMO_EVT_CRIT_PROC_STOP, : "BTS: signal %d (%s) received", signal, : strsignal(signal)); > this is actually wrong. […] Agree with Harald here. -- To view, visit https://gerrit.osmocom.org/13268 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I83c4fa9ebd519299fd54b37b5d95d6d7c1da24f6 Gerrit-Change-Number: 13268 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Fri, 15 Mar 2019 20:27:30 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
