Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13136 )
Change subject: vlr_subscr: use osmo_use_count ...................................................................... Patch Set 2: (3 comments) https://gerrit.osmocom.org/#/c/13136/2/src/libmsc/gsm_04_08.c File src/libmsc/gsm_04_08.c: https://gerrit.osmocom.org/#/c/13136/2/src/libmsc/gsm_04_08.c@1804 PS2, Line 1804: "conn" no #define here? See my comment about in-line literal strings vs. #defines and the risk of undiscovered typos in the use_count libosmocore patchset. https://gerrit.osmocom.org/#/c/13136/2/src/libmsc/ran_conn.c File src/libmsc/ran_conn.c: https://gerrit.osmocom.org/#/c/13136/2/src/libmsc/ran_conn.c@555 PS2, Line 555: vlr_subscr_put(conn->vsub, "conn"); no #define here? See my comment about in-line literal strings vs. #defines and the risk of undiscovered typos in the use_count libosmocore patchset. https://gerrit.osmocom.org/#/c/13136/2/src/libmsc/sgs_iface.c File src/libmsc/sgs_iface.c: https://gerrit.osmocom.org/#/c/13136/2/src/libmsc/sgs_iface.c@101 PS2, Line 101: vlr_subscr_get(vsub, "conn"); no #define here? See my comment about in-line literal strings vs. #defines and the risk of undiscovered typos in the use_count libosmocore patchset. -- To view, visit https://gerrit.osmocom.org/13136 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib06d030e8464abe415ff597d462ed40eeddef475 Gerrit-Change-Number: 13136 Gerrit-PatchSet: 2 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Harald Welte <[email protected]> Gerrit-CC: Max <[email protected]> Gerrit-Comment-Date: Sat, 16 Mar 2019 08:06:55 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
