Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13296 )
Change subject: main: remove wrong call to oml_fail_rep() on SIGUSR1/2 and SIGABRT ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/13296/1/src/common/main.c File src/common/main.c: https://gerrit.osmocom.org/#/c/13296/1/src/common/main.c@a195 PS1, Line 195: One could argument it actually makes sense to move it upwards under SIGABRT and fall through, but I'm not sure it's a good idea messing around while in SIGABORT since we are modifying stuff in an unknown state. -- To view, visit https://gerrit.osmocom.org/13296 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I99e637496afff2530425b89c6e9befc76db24906 Gerrit-Change-Number: 13296 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 18 Mar 2019 11:35:45 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
