Max has posted comments on this change. ( https://gerrit.osmocom.org/13301 )
Change subject: Add scripts/osmocom-list-commits.sh ...................................................................... Patch Set 2: Code-Review+1 (2 comments) https://gerrit.osmocom.org/#/c/13301/1/scripts/osmocom-list-commits.sh File scripts/osmocom-list-commits.sh: https://gerrit.osmocom.org/#/c/13301/1/scripts/osmocom-list-commits.sh@51 PS1, Line 51: > Made it optional with the current patch: […] Don't know what would be most common use-case - if it's mostly M2M than it's probably better to default to no-header case. https://gerrit.osmocom.org/#/c/13301/1/scripts/osmocom-list-commits.sh@62 PS1, Line 62: head_commit="$(get_head_commit "$repo")" > The output format was based on an existing Makefile, that's why the '=' is > there. […] Curious, which Makefile is it? -- To view, visit https://gerrit.osmocom.org/13301 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91cab0139229e6c1c67e889d33b3d984025bc9da Gerrit-Change-Number: 13301 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Comment-Date: Mon, 18 Mar 2019 14:47:44 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
