Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13275 )
Change subject: oc2gbts_mgr: use osmo_init_logging2() instead of osmo_init_logging() ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/13275/1/src/osmo-bts-oc2g/misc/oc2gbts_mgr.c File src/osmo-bts-oc2g/misc/oc2gbts_mgr.c: https://gerrit.osmocom.org/#/c/13275/1/src/osmo-bts-oc2g/misc/oc2gbts_mgr.c@276 PS1, Line 276: tall_msgb_ctx = talloc_named_const(tall_mgr_ctx, 1, "msgb"); this should also be converted towards using msgb_talloc_ctx_init in a separate patch, forall code in this repository. https://gerrit.osmocom.org/#/c/13275/1/src/osmo-bts-oc2g/misc/oc2gbts_mgr.c@279 PS1, Line 279: tall_msgb_ctx why tall_msgb_ctx and not tall_mgr_ctx? Why would logging relate to message buffers? -- To view, visit https://gerrit.osmocom.org/13275 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebc80cd1f77f10a879d4536d788377f522dd853f Gerrit-Change-Number: 13275 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Daniel Willmann <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Tue, 19 Mar 2019 13:02:36 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
