Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13326 )
Change subject: Add example systemd user unit files ...................................................................... Patch Set 2: > I think it makes more sense to have all *.service files in a single > directory: $PROJECT/contrib/systemd/... Oh good point, I didn't notice they were under src/target/... I agree here with Vadim. However, I still want to have them placed under /user/ subdir. systemd user service and sytem services files are different stuff and it's better not having them together in same directory in order to avoid confusion (systemd does install them to different directories too). Regading Max's splitting argument, we can still do that easily if they are placed in $PROJECT/contrib/systemd. -- To view, visit https://gerrit.osmocom.org/13326 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc6b571cfb7796af1cfcf0af2d4e12e53f7a4ee6 Gerrit-Change-Number: 13326 Gerrit-PatchSet: 2 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Wed, 20 Mar 2019 11:30:18 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
