Max has posted comments on this change. ( https://gerrit.osmocom.org/13394 )
Change subject: add osmo_str_startswith() ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/13394/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/13394/1//COMMIT_MSG@31 PS1, Line 31: Arguably, strstr(a, b) == a does the same thing, but it searches the entire Why is that a problem exactly? Why do we need in our API smth which duplicates <string.h> function? -- To view, visit https://gerrit.osmocom.org/13394 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2ffb0e9a870dd52e081c7e66d8818057d159513 Gerrit-Change-Number: 13394 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Comment-Date: Mon, 25 Mar 2019 12:31:57 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
