Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13398 )
Change subject: core/linuxlist.h: fix and unify Doxygen documentation ...................................................................... Patch Set 1: (4 comments) https://gerrit.osmocom.org/#/c/13398/1/include/osmocom/core/linuxlist.h File include/osmocom/core/linuxlist.h: https://gerrit.osmocom.org/#/c/13398/1/include/osmocom/core/linuxlist.h@50 PS1, Line 50: /*! Define a new llist_head pointing to another llist_head. > another is confusing here, specially because immediatelly afterwards it' used > to point to itself in […] Agree, done. https://gerrit.osmocom.org/#/c/13398/1/include/osmocom/core/linuxlist.h@69 PS1, Line 69: * Insert a new entry between two known consecutive entries. > No need for extra line. You can start it with "/*! Insert", see functions > below. This is an internal function, so we probably don't need to have any Doxygen documentation for it. I just made it look similar to __llist_del's documentation. https://gerrit.osmocom.org/#/c/13398/1/include/osmocom/core/linuxlist.h@85 PS1, Line 85: * \param _new a new entry to be added. > "the entry to be added". Done https://gerrit.osmocom.org/#/c/13398/1/include/osmocom/core/linuxlist.h@86 PS1, Line 86: * \param head head of linked list to add it after. > "add it after" is quite misleading here. […] Done -- To view, visit https://gerrit.osmocom.org/13398 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac67bdb9d5fbf7c222d04858967337f2428d6a94 Gerrit-Change-Number: 13398 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Mon, 25 Mar 2019 15:06:58 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
