Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13400 )
Change subject: logging_gsmtap.c: document all params of log_target_create_gsmtap() ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/13400/1/src/logging_gsmtap.c File src/logging_gsmtap.c: https://gerrit.osmocom.org/#/c/13400/1/src/logging_gsmtap.c@123 PS1, Line 123: * \param[in] ofd_wq_mode register osmo_wqueue (1) or not (0) should actually be (true) (false) -- To view, visit https://gerrit.osmocom.org/13400 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id7bd6b4fb4be571af351f77aa4a59b9e1076434f Gerrit-Change-Number: 13400 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Mon, 25 Mar 2019 15:10:12 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
