Max has posted comments on this change. ( https://gerrit.osmocom.org/13403 )
Change subject: bts.h: always include C-headers ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13403/1/src/bts.h File src/bts.h: https://gerrit.osmocom.org/#/c/13403/1/src/bts.h@44 PS1, Line 44: #endif > I'm pointing out how usually C headers are guarded on C++ code That doesn't seem relevant: the headers below #ifdef __cplusplus in a current patch version are C++ headers which should not be included directly into .c file which use bts.h. Especially if they were not included before this patch. And even more so if the only reason to include them is "that's how it usually looks like". -- To view, visit https://gerrit.osmocom.org/13403 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I85b7dc8e8786671a054af2f1e7d836b863a25e60 Gerrit-Change-Number: 13403 Gerrit-PatchSet: 1 Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Daniel Willmann <dwillm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Comment-Date: Mon, 25 Mar 2019 21:24:55 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
