osmith has posted comments on this change. ( https://gerrit.osmocom.org/13204 )
Change subject: BSSGP: use variable for NSEI ...................................................................... Patch Set 3: (2 comments) https://gerrit.osmocom.org/#/c/13204/3/src/gb/gprs_bssgp.c File src/gb/gprs_bssgp.c: https://gerrit.osmocom.org/#/c/13204/3/src/gb/gprs_bssgp.c@848 PS3, Line 848: return bssgp_tx_fc_bvc_ack(nsei, *TLVP_VAL(tp, BSSGP_IE_TAG), : msgb_bvci(msg)); What's the benefit of introducing the nsei variable here? Since it is used only in one place, and there's no dedicated bvci variable either. https://gerrit.osmocom.org/#/c/13204/3/src/gb/gprs_bssgp_util.c File src/gb/gprs_bssgp_util.c: https://gerrit.osmocom.org/#/c/13204/3/src/gb/gprs_bssgp_util.c@240 PS3, Line 240: nsei same here -- To view, visit https://gerrit.osmocom.org/13204 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I919a717ca22646849d6ec7f62c677c536db0ed31 Gerrit-Change-Number: 13204 Gerrit-PatchSet: 3 Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: André Boddenberg <dr.bl...@gmail.com> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-CC: Harald Welte <lafo...@gnumonks.org> Gerrit-Comment-Date: Tue, 26 Mar 2019 14:51:55 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
