Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13418 )
Change subject: nanobts: use libosmocore's osmo_store*() for OML attr. patching ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13418/1/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c File src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c: https://gerrit.osmocom.org/#/c/13418/1/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c@207 PS1, Line 207: osmo_store16be(bts->gprs.nsvc[0].remote_port, &buf[0]); > but the previous patch_16/32() always had a htons/htonl inside, so I think > for this line and the two […] Ah indeed, I didn't see the htnol and htons. -- To view, visit https://gerrit.osmocom.org/13418 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28cfb09f224072db9889a89923a3da15a6070e2a Gerrit-Change-Number: 13418 Gerrit-PatchSet: 1 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Wed, 27 Mar 2019 11:29:19 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
