Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13450 )
Change subject: libmsc/sms_queue.c: fix memleak in smsq_take_next_sms() ...................................................................... Patch Set 2: (1 comment) otherwise, inter-msc branch wise, ack to merge https://gerrit.osmocom.org/#/c/13450/2/tests/sms_queue/sms_queue_test.c File tests/sms_queue/sms_queue_test.c: https://gerrit.osmocom.org/#/c/13450/2/tests/sms_queue/sms_queue_test.c@148 PS2, Line 148: talloc_free(sms); all of these should probably also be sms_free() -- To view, visit https://gerrit.osmocom.org/13450 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iad5e4d84d8d410ea43d5907e9ddf6e5fdb55bc7a Gerrit-Change-Number: 13450 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Comment-Date: Fri, 29 Mar 2019 14:54:46 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
