Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13479 )
Change subject: fix USSD routing to multiple MSC ...................................................................... Patch Set 4: (1 comment) This is an improvement, but... https://gerrit.osmocom.org/#/c/13479/4/src/hlr_ussd.c File src/hlr_ussd.c: https://gerrit.osmocom.org/#/c/13479/4/src/hlr_ussd.c@338 PS4, Line 338: ss_tx_error(ss, true, GSM0480_ERR_CODE_UNKNOWN_SUBSCRIBER); well. If we can't find a subscriber, then we also can't send an error back to it. so should probably also somehow remember which MSC initiated the session? For entirely MT USSD, we still need to resolve the VLR from IMSI alone, but for MO USSD we can use the name of the VLR that contacted the HLR. -- To view, visit https://gerrit.osmocom.org/13479 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I18067bfadd33a6bc59a9ee336b6937313826fce3 Gerrit-Change-Number: 13479 Gerrit-PatchSet: 4 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Comment-Date: Tue, 02 Apr 2019 02:50:23 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
