Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13419 )
Change subject: Use osmo_lcls instead of anonymous struct ...................................................................... Patch Set 1: Code-Review-1 (1 comment) I don't see a need for using dynamic allocations at all, the 'struct osmo_lcls' is present in all subscr_conn, so why not make it a static member? https://gerrit.osmocom.org/#/c/13419/1/include/osmocom/bsc/gsm_data.h File include/osmocom/bsc/gsm_data.h: https://gerrit.osmocom.org/#/c/13419/1/include/osmocom/bsc/gsm_data.h@295 PS1, Line 295: struct osmo_lcls *par; /* LCLS parameters */ why is this not a static member here? Your patch doesn't only change from discrete members to 'struct osmo_lcls', but it also switches from static to dynamic allocation. I support the former, but I don't undestand why the latter change is required. -- To view, visit https://gerrit.osmocom.org/13419 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0f2c2a065755d9051fc7d7ce52c19ab0b7d9288a Gerrit-Change-Number: 13419 Gerrit-PatchSet: 1 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Comment-Date: Mon, 08 Apr 2019 07:39:44 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
