Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13570 )
Change subject: ggsn: Fix build_ipcp_pco() in presence of invalid IPCP content ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13570/1/ggsn/ggsn.c File ggsn/ggsn.c: https://gerrit.osmocom.org/#/c/13570/1/ggsn/ggsn.c@534 PS1, Line 534: ipcp_len = osmo_load16be(ipcp + 2); /* 1=code + 1=id */ ipcp_len can be dropped completely in favour of pco_ipcp->length. -- To view, visit https://gerrit.osmocom.org/13570 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8e9cffde092c8c5824abfaeecb742afcf949802c Gerrit-Change-Number: 13570 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Thu, 11 Apr 2019 14:23:52 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
