Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13563 )
Change subject: ggsn: Verify that there are no duplicate PCO protocolIDs ...................................................................... Patch Set 3: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/13563/3/ggsn_tests/GGSN_Tests.ttcn File ggsn_tests/GGSN_Tests.ttcn: https://gerrit.osmocom.org/#/c/13563/3/ggsn_tests/GGSN_Tests.ttcn@773 PS3, Line 773: f_PCO_ensure_no_duplicates(ctx.pco_neg); What about adding this kind of check inside f_pdp_ctx_act so we don't need to put it in every test? To take into account cases like TC_pdp4_act_deact_with_separate_dns(), I'd actually modify f_PCO_ensure_no_duplicates() to count number of duplicates sent in request and making sure we answer each of them, so req.count(prot_type) == resp.count(prot_type), for each prot_type. -- To view, visit https://gerrit.osmocom.org/13563 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d439dab1696196cd125f4d7113b426f1711a405 Gerrit-Change-Number: 13563 Gerrit-PatchSet: 3 Gerrit-Owner: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Thu, 11 Apr 2019 19:14:14 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
