Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13564 )
Change subject: ggsn: Add TC_pdp4_act_deact_ipcp_pap_broken() ...................................................................... Patch Set 5: Code-Review+1 (2 comments) https://gerrit.osmocom.org/#/c/13564/5/ggsn_tests/GGSN_Tests.ttcn File ggsn_tests/GGSN_Tests.ttcn: https://gerrit.osmocom.org/#/c/13564/5/ggsn_tests/GGSN_Tests.ttcn@943 PS5, Line 943: setverdict(fail, "PAP isn't an AuthenticateAck: ", pap); so iiuc this means some code is needed in osmo-ggsn which answers this and basically allows everybody no matter the PAP credentials provided (as if PAP was not used, as until now). https://gerrit.osmocom.org/#/c/13564/5/library/GTP_Templates.ttcn File library/GTP_Templates.ttcn: https://gerrit.osmocom.org/#/c/13564/5/library/GTP_Templates.ttcn@466 PS5, Line 466: protoIDContents := '0100003c0444435338323700bc1c08087c1508083e00790000150808fd06000001000000000000000000000000000000000000000000000000000000'O lol. Some description/comment here would be welcome. -- To view, visit https://gerrit.osmocom.org/13564 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie89d984ed9e26fbbb2e4914bdb8623446d462a4c Gerrit-Change-Number: 13564 Gerrit-PatchSet: 5 Gerrit-Owner: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Thu, 11 Apr 2019 19:26:23 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
