Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13575 )
Change subject: add OSMO_IMSI_SIZE ...................................................................... Patch Set 3: interesting, I see "size" as synonymous with "buf_size". Even more generally appropriate, next guy prefers ARRAY_SIZE or ALLOC_SIZE or DUMP_SIZE or CACHE_SIZE..., all just comes down to size. I don't mind changing the name, though it does add more work to adjust other patches for a pretty moot change... -- To view, visit https://gerrit.osmocom.org/13575 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id11ada4c96b79f7f0ad58185ab7dbf24622fb770 Gerrit-Change-Number: 13575 Gerrit-PatchSet: 3 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-CC: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Thu, 11 Apr 2019 23:04:24 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
