Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13608 )
Change subject: ggsn: Add minimalistic PAP support ...................................................................... Patch Set 4: (2 comments) https://gerrit.osmocom.org/#/c/13608/4/ggsn/ggsn.c File ggsn/ggsn.c: https://gerrit.osmocom.org/#/c/13608/4/ggsn/ggsn.c@531 PS4, Line 531: if (pap_in->len < 1) That's wrong, because len includes header according to line 501. Also, you are accessing data[0] and data[1], so you miss one byte len. if (pap_in->len < sizeof(*pap_in) + 2) https://gerrit.osmocom.org/#/c/13608/4/ggsn/ggsn.c@535 PS4, Line 535: if (pap_in->len < 1 + peer_id_len) if (pap_in->len < sizeof(*pap_in) + 2 + peer_id_len) -- To view, visit https://gerrit.osmocom.org/13608 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I81875f30f9f1497199253497f84718510747f731 Gerrit-Change-Number: 13608 Gerrit-PatchSet: 4 Gerrit-Owner: Harald Welte <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Fri, 12 Apr 2019 13:16:19 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
