Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12860 )
Change subject: GSUP: add inter-MSC handover related msgs and IEs ...................................................................... Patch Set 9: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/12860/9/include/osmocom/gsm/gsup.h File include/osmocom/gsm/gsup.h: https://gerrit.osmocom.org/#/c/12860/9/include/osmocom/gsm/gsup.h@369 PS9, Line 369: cause_rr_set An alternative solution is to use pointers, i.e.: uint8_t *cause_rr; enum gsm0808_cause *cause_bssap; This is how we do for sm_rp_cause and sm_rp_mms, so there is no need for such bool flags. -- To view, visit https://gerrit.osmocom.org/12860 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic00b0601eacff6d72927cea51767801142ee75db Gerrit-Change-Number: 12860 Gerrit-PatchSet: 9 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Daniel Willmann <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Fri, 12 Apr 2019 15:29:28 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
