Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13640 )
Change subject: configure.ac: properly check for libdbi SQLite3 driver ...................................................................... Patch Set 1: Code-Review-1 What you are doing here doesn't make much sense to me, since you check for some runtime dependency during build time. That doesn't make sense if buildhost != runhost. We don't need libdbi-sqlite to build the software. It would only make sense if we require libdbi-sqlite to run the unit tests, and in that case it should only be checked during make check or similar. -- To view, visit https://gerrit.osmocom.org/13640 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f7c719d41d9be28527e4ac3a8b2869c87337074 Gerrit-Change-Number: 13640 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Mon, 15 Apr 2019 13:30:16 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes
