Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13660 )
Change subject: cleanup: remove comment copied from -uhd ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/13660/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/13660/1//COMMIT_MSG@7 PS1, Line 7: cleanup: remove comment copied from -uhd Better indicate the scope of the patch first. And you are not only changing comment (yes, I know actually that code is not used at all). "lms: Remove wrong unused code copied from -uhd" https://gerrit.osmocom.org/#/c/13660/1/Transceiver52M/device/lms/LMSDevice.cpp File Transceiver52M/device/lms/LMSDevice.cpp: https://gerrit.osmocom.org/#/c/13660/1/Transceiver52M/device/lms/LMSDevice.cpp@551 PS1, Line 551: /* UNUSED on limesdr (only used on usrp1/2) */ Remove extra whitespace at the end. Better explain why is only used on usrp1/2 (TX_WINDOW_foo right?) -- To view, visit https://gerrit.osmocom.org/13660 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2bc7fcfa429d1f82c2d8e95d31dfed367f2b3f9d Gerrit-Change-Number: 13660 Gerrit-PatchSet: 1 Gerrit-Owner: roh <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Tue, 16 Apr 2019 15:40:05 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
