Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13662 )
Change subject: move LMS_GetLPFBWRange and LMS_Calibrate calls from open to start (bw, freq, power need to be set) ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/13662/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/13662/1//COMMIT_MSG@7 PS1, Line 7: move LMS_GetLPFBWRange and LMS_Calibrate calls from open to start (bw, freq, power need to be set) Same as before: * prepend "lms:" * Move description on why it is done (your parenthesis) out of first line and extend it. https://gerrit.osmocom.org/#/c/13662/1/Transceiver52M/device/lms/LMSDevice.cpp File Transceiver52M/device/lms/LMSDevice.cpp: https://gerrit.osmocom.org/#/c/13662/1/Transceiver52M/device/lms/LMSDevice.cpp@377 PS1, Line 377: LOGC(DDEV, INFO) << "Setting LPFBW chan " << chan; >From line 361 up to here (at least it seems) to be totally independent from >channel, so you shouldn't be calling it for each chan. Better Move that out >and pass lpfbw_rx and lpfbw_tx to do_filters(). -- To view, visit https://gerrit.osmocom.org/13662 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1090effdf0f43e5183a402e4c1a1ffe5abdefd37 Gerrit-Change-Number: 13662 Gerrit-PatchSet: 1 Gerrit-Owner: roh <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Tue, 16 Apr 2019 15:52:25 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
