Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13681 )
Change subject: add sim-atr command ...................................................................... Patch Set 4: (3 comments) https://gerrit.osmocom.org/#/c/13681/4/sysmoOCTSIM/main.c File sysmoOCTSIM/main.c: https://gerrit.osmocom.org/#/c/13681/4/sysmoOCTSIM/main.c@248 PS4, Line 248: settings.clkdiv = SIM_CLKDIV_8; : ncn8025_set(slotnr, &settings); : // set card voltage to 3.0 V (the most supported) : // note: according to ISO/IEC 7816-3:2006 no voltage should damage the card, and you should cycle from low to high : settings.vsel = SIM_VOLT_3V0; : ncn8025_set(slotnr, &settings); : // provide power (the NCN8025 should perform the activation according to spec) : // note: activation sequence is documented in ISO/IEC 7816-3:2006 section 6.2 : settings.cmdvcc = true; : ncn8025_set(slotnr, &settings); those could all be part of one ncn8025_set. I will test and update. https://gerrit.osmocom.org/#/c/13681/4/sysmoOCTSIM/main.c@259 PS4, Line 259: 400 * 10000 / 2500 can that really safely be expressed in uint16_t arithmetic? delay_us uses a 16bit argument :/ https://gerrit.osmocom.org/#/c/13681/4/sysmoOCTSIM/main.c@261 PS4, Line 261: settings.rstin = true; the logic of rstin has changed in master yesterday, I will update + test -- To view, visit https://gerrit.osmocom.org/13681 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30b284cab60a50d4cd3080f46f4d332193bbf1ee Gerrit-Change-Number: 13681 Gerrit-PatchSet: 4 Gerrit-Owner: Kévin Redon <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Wed, 17 Apr 2019 08:31:19 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
