Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13709 )
Change subject: common/oml.c: fix: properly encode NM_ATT_SW_CONFIG ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13709/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/13709/1//COMMIT_MSG@17 PS1, Line 17: However, unlike OsmoBSC the old OpenBSC does not expect this : encapsulation, thus after this change it will be unable to : parse the 'SW Descriptions'. did you check how this is with a nanoBTS? I think it's best to align with how they implement this. Also, the big question is what we do in terms of compatibility. Maybe add it twice: both in the correct and in the incorrect form? -- To view, visit https://gerrit.osmocom.org/13709 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id26104719891944f3e2151df362bd45bb057a9c5 Gerrit-Change-Number: 13709 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Fri, 19 Apr 2019 16:00:07 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
