Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13734 )
Change subject: library/L1CTL_Types.ttcn: add L1CTL_EXT_RACH_REQ message ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/13734/1/library/L1CTL_Types.ttcn File library/L1CTL_Types.ttcn: https://gerrit.osmocom.org/#/c/13734/1/library/L1CTL_Types.ttcn@51 PS1, Line 51: L1CTL_DATA_ABS_REQ /*!< FIXME: no such message in OsmocomBB */ this will break the existing (but long not executed) GPRS/PCU tests using virt_phy. Can you not just simply use the next unallocated message type, rather than changing the numeric value of L1CTL_DATA_ABS_REQ? L1CTL_DATA_ABS_REQ is used to transmit a MAC block at a given fixed frame number. -- To view, visit https://gerrit.osmocom.org/13734 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If037cb2f2687697f168d10a033eeb20d20183328 Gerrit-Change-Number: 13734 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Comment-Date: Mon, 22 Apr 2019 08:43:51 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
