Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/13735 )

Change subject: BTS_Tests.ttcn: add TC_pcu_ext_rach_content() for 11-bit RACH
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/13735/1/bts/BTS_Tests.ttcn
File bts/BTS_Tests.ttcn:

https://gerrit.osmocom.org/#/c/13735/1/bts/BTS_Tests.ttcn@994
PS1, Line 994: /* 2047 is 0x7ff (0b11111111111) */
you could use f_rnd_int(bit2int('11111111111'B)) or f_rnd_int(hex2int('7ff'H)) 
and avoid the comment



--
To view, visit https://gerrit.osmocom.org/13735
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8fe156aeac9de3dc1e71a4950821d4942ba9a253
Gerrit-Change-Number: 13735
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Comment-Date: Mon, 22 Apr 2019 09:24:24 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Reply via email to