Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/13738


Change subject: libosmo-mgcp: Use trunk type during endpoint allocation
......................................................................

libosmo-mgcp: Use trunk type during endpoint allocation

This way we prepare it to add more endpoint types in the future (osmux)
and also make it clear that E1 endpoint specifics allocation is still
missing.

Change-Id: I7633b5287a436c11f0bbbdbaef1cf59a051a2471
---
M src/libosmo-mgcp/mgcp_protocol.c
1 file changed, 12 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/38/13738/1

diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c
index 4121b9f..2acc7fd 100644
--- a/src/libosmo-mgcp/mgcp_protocol.c
+++ b/src/libosmo-mgcp/mgcp_protocol.c
@@ -1677,9 +1677,18 @@
                tcfg->endpoints[i].cfg = tcfg->cfg;
                tcfg->endpoints[i].tcfg = tcfg;

-               /* NOTE: Currently all endpoints are of type RTP, this will
-                * change when new variations are implemented */
-               tcfg->endpoints[i].type = &ep_typeset.rtp;
+               switch (tcfg->trunk_type) {
+               case MGCP_TRUNK_VIRTUAL:
+                       tcfg->endpoints[i].type = &ep_typeset.rtp;
+                       break;
+               case MGCP_TRUNK_E1:
+                       /* FIXME: Implement E1 allocation */
+                       LOGP(DLMGCP, LOGL_FATAL, "E1 trunks not 
implemented!\n");
+                       break;
+               default:
+                       osmo_panic("Cannot allocate unimplemented trunk type 
%d! %s:%d\n",
+                                  tcfg->trunk_type, __FILE__, __LINE__);
+               }
        }

        tcfg->number_endpoints = tcfg->vty_number_endpoints;

--
To view, visit https://gerrit.osmocom.org/13738
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7633b5287a436c11f0bbbdbaef1cf59a051a2471
Gerrit-Change-Number: 13738
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <[email protected]>

Reply via email to