Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13755 )
Change subject: trx_toolkit/data_msg.py: fix TOA256 MIN/MAX constants ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13755/1/src/target/trx_toolkit/data_msg.py File src/target/trx_toolkit/data_msg.py: https://gerrit.osmocom.org/#/c/13755/1/src/target/trx_toolkit/data_msg.py@301 PS1, Line 301: TOA256_MIN = -32768 You could explain in the comment above where do these values come from rather than repeating them. -- To view, visit https://gerrit.osmocom.org/13755 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d4e1fea9d07f2c49f01e6644d1c0d1dc8cf4e40 Gerrit-Change-Number: 13755 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Tue, 23 Apr 2019 19:34:25 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
