Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13761 )
Change subject: gb_proxy.h: Add missing comments; improve comments ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/#/c/13761/1/include/osmocom/sgsn/gb_proxy.h File include/osmocom/sgsn/gb_proxy.h: https://gerrit.osmocom.org/#/c/13761/1/include/osmocom/sgsn/gb_proxy.h@129 PS1, Line 129: /* should we keep per-subscriber state even after de-registration? */ perhaps adding the word "cached" here makes sense to understand better what the storing is aimed at, and also to understand caching too much means lots of memory :) https://gerrit.osmocom.org/#/c/13761/1/include/osmocom/sgsn/gb_proxy.h@194 PS1, Line 194: /* TLLI on the SGSN side (can be different in case of P-TMSI patching */ missing ")" https://gerrit.osmocom.org/#/c/13761/1/include/osmocom/sgsn/gb_proxy.h@199 PS1, Line 199: /* timestamp when we last saw any contact with this UE */ "had any contact" -- To view, visit https://gerrit.osmocom.org/13761 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I61bdd3b1cec037bce825c234a8a274b70629adc8 Gerrit-Change-Number: 13761 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Tue, 23 Apr 2019 20:56:18 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
