Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13764 )
Change subject: LLC: Don't blindly assume all LLC frames have data payload ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/13764/2/src/gprs/gprs_llc.c File src/gprs/gprs_llc.c: https://gerrit.osmocom.org/#/c/13764/2/src/gprs/gprs_llc.c@961 PS2, Line 961: /* set l3 layer & remove the fcs */ so do we need the fcs for kind of messages where there's not l3? Othewise I don't see the benefit from doing this. Because in the previous code msg->l3h would still be set to NULL and message be empty (which is fine I guess if we don't care about lower layers anymore). -- To view, visit https://gerrit.osmocom.org/13764 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51bbd0f2c618d477a037af343ff41de1c8a5a3ae Gerrit-Change-Number: 13764 Gerrit-PatchSet: 2 Gerrit-Owner: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Keith Whyte <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Tue, 23 Apr 2019 21:03:02 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
