Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13768 )
Change subject: common/rsl.c: fix unaligned pointers in rsl_add_rtp_stats() ...................................................................... Patch Set 1: > Maybe it's the __attribute((packed)) which is putting clang off? Yep, exactly. All warnings are triggered by policy -Waddress-of-packed-member. In general, I don't see big advantages of using a struct here, no matter is it packed or not. We still have to memset() it, and still need to convert all its members to big-endian... -- To view, visit https://gerrit.osmocom.org/13768 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifba33cfd8edeccc99a21c7d076db7119c29d4f40 Gerrit-Change-Number: 13768 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Wed, 24 Apr 2019 08:07:18 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
