Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13767 )
Change subject: gprs_llc: Correctly refuse any ABM command (SABM, DISC) with DM ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/13767/2/src/gprs/gprs_llc.c File src/gprs/gprs_llc.c: https://gerrit.osmocom.org/#/c/13767/2/src/gprs/gprs_llc.c@818 PS2, Line 818: #if 0 Please add a comment explaining why this block is disabled. It's clean for me because I read OS#3953. Otherwise one would need to guess. Something like: /* We don't support ABM, so we refuse it */ would be great. -- To view, visit https://gerrit.osmocom.org/13767 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie8b8e16d5a68f19f21dc4fdb5703c8a794e0173c Gerrit-Change-Number: 13767 Gerrit-PatchSet: 2 Gerrit-Owner: Harald Welte <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Wed, 24 Apr 2019 08:22:50 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
