Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13756 )
Change subject: Add expect script: 'vty' for easy access to all vtys ...................................................................... Patch Set 1: The more "canonical" way for the port numbers part is of course to add them to /etc/services so that you can do something like "telnet localhost osmo-msc". I used to do that. However,adding records to that file during package installation isn't very elegant, and there is no /etc/services.d or something along those lines. Another approach would be to write a NSS module (see http://www.gnu.org/software/libc/manual/html_node/Name-Service-Switch.html#Name-Service-Switch) which would either have a compiled-in list of service name/port mappings, or (even better) parse the /etc/osmocom/osmo*.cfg files to create those mappings from the config files. In that case you would automatically get aliases for the port numbers that you configured. Yet another approach is to use http://git.osmocom.org/libtelnet/ to create an osmocom-extended telnet client program which would have capabilities specific to the osmcoom vty, including finding the port numbers from the config files (or compiled-in defaults) and issue the VTY commands for logging, etc. using some local commands, maybe prefixed by @. -- To view, visit https://gerrit.osmocom.org/13756 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice4532be7cb3139da29cb9d84dd4769e8d826dfa Gerrit-Change-Number: 13756 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Whyte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-CC: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Wed, 24 Apr 2019 08:42:25 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
