Mykola Shchetinin has posted comments on this change. ( https://gerrit.osmocom.org/13744 )
Change subject: gprs_gmm: send Service Reject when no PDP ctxs are available. ...................................................................... Patch Set 6: (2 comments) https://gerrit.osmocom.org/#/c/13744/5/src/gprs/gprs_gmm.c File src/gprs/gprs_gmm.c: https://gerrit.osmocom.org/#/c/13744/5/src/gprs/gprs_gmm.c@1620 PS5, Line 1620: * network. > Please also leave the old comment together with the new additions, it's handy > to understand what the […] Done https://gerrit.osmocom.org/#/c/13744/5/src/gprs/gprs_gmm.c@1628 PS5, Line 1628: size_t i; > Probably much clear to have simple pdp_nsapi++ in the foor loop clause, then > in body have: […] Yes, I should have used "i" for indexing pdp_status. "i" is also used in the loop condition, so it is better to leave it there. I could put it in the end of the loop, but then due to "continue" it doesn't get changed always. -- To view, visit https://gerrit.osmocom.org/13744 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If610cbef17c25ec44e65d4f1b2340d102c560437 Gerrit-Change-Number: 13744 Gerrit-PatchSet: 6 Gerrit-Owner: Mykola Shchetinin <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Mykola Shchetinin <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Wed, 24 Apr 2019 12:09:15 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
