Alexander Chemeris has posted comments on this change. ( https://gerrit.osmocom.org/13723 )
Change subject: osmo-bts-trx: distinguish 11-bit Access Bursts by synch. sequence ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/13723/4/src/osmo-bts-trx/scheduler_trx.c File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/#/c/13723/4/src/osmo-bts-trx/scheduler_trx.c@750 PS4, Line 750: (synch_seq_ref[i][j] == '1' ? -1 : 1) > In general, I am agree. […] Just add the 0/1 sequence as a comment. Given that 1/-1 sequence can be produced from a 0/1 sequence with a regexp, I don't see any practical issues with this - comparing 1/-1 to 0/1 sequence is super easy and straightforward, and if you want to see it with your eyes - here it is, in the comment. You can do this but it's ugly: #define b0 1 #define b1 -1 [RACH_SYNCH_SEQ_TS2] = [b1,b1,b1,b0,b1,b1,b1,b1,b0,b0,b1,b0,b0,b1,b1,b1,b0,b1,b0,b1,b0,b1,b1,b0,b0,b0,b0,b0,b1,b1,b0,b1,b1,b0,b1,b1,b1,b0,b1,b1,b1] #undef b0 #undef b1 or (no less ugly): #define O 1 #define I -1 [RACH_SYNCH_SEQ_TS2] = [I,I,I,O,I,I,I,I,O,O,I,O,O,I,I,I,O,I,O,I,O,I,I,O,O,O,O,O,I,I,O,I,I,O,I,I,I,O,I,I,I] #undef O #undef I Just an 1/-1 array and a comment with 0/1 string is the best choice. -- To view, visit https://gerrit.osmocom.org/13723 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb6d27c6589965c8b59a6d2598a7c43fd860f284 Gerrit-Change-Number: 13723 Gerrit-PatchSet: 4 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Alexander Chemeris <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Wed, 24 Apr 2019 20:44:48 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
